Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to aiohttp, async #6

Merged
merged 3 commits into from
Oct 20, 2020
Merged

Migrate to aiohttp, async #6

merged 3 commits into from
Oct 20, 2020

Conversation

bjw-s
Copy link
Contributor

@bjw-s bjw-s commented Oct 19, 2020

Required for cgarwood/homeassistant-fullykiosk#23

Also fixes the setAudioVolume command, as it was passing volume instead of level

Copy link
Owner

@cgarwood cgarwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Just 1 super-small comment.

fullykiosk/__init__.py Outdated Show resolved Hide resolved
@bjw-s
Copy link
Contributor Author

bjw-s commented Oct 20, 2020

This one should be done I think :) I added some additional error handling so the user will receive an error message when a service call goes wrong (e.g. trying to reboot a device without the correct root permissions)

@cgarwood
Copy link
Owner

Awesome!

@cgarwood cgarwood merged commit 15cff33 into cgarwood:master Oct 20, 2020
@bjw-s bjw-s deleted the exception branch October 20, 2020 12:37
JordiSaPe pushed a commit to JordiSaPe/python-fullykiosk that referenced this pull request Jun 24, 2024
* Migrate to aiohttp, async

* Add error handling

* Remove unused import
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants